mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Guangya Liu <gyliu...@gmail.com>
Subject Re: Review Request 49232: Added appcManifest to ImageInfo and ProvisionInfo.
Date Sun, 26 Jun 2016 02:52:58 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49232/#review139469
-----------------------------------------------------------




src/slave/containerizer/mesos/containerizer.cpp (lines 78 - 83)
<https://reviews.apache.org/r/49232/#comment204700>

    adjust the order



src/slave/containerizer/mesos/containerizer.cpp (line 311)
<https://reviews.apache.org/r/49232/#comment204705>

    s/AppcRuntimeIsolatorProcess/AppCRuntimeIsolatorProcess



src/slave/containerizer/mesos/provisioner/appc/store.cpp (lines 209 - 210)
<https://reviews.apache.org/r/49232/#comment204703>

    add a blank line here



src/slave/containerizer/mesos/provisioner/appc/store.cpp (lines 211 - 212)
<https://reviews.apache.org/r/49232/#comment204704>

    VLOG(1) << "Failed to get manifest for image  '"
            << appc.SerializeAsString() << "'";



src/slave/containerizer/mesos/provisioner/provisioner.hpp (line 63)
<https://reviews.apache.org/r/49232/#comment204701>

    s/Appc/AppC



src/slave/containerizer/mesos/provisioner/provisioner.cpp (lines 334 - 336)
<https://reviews.apache.org/r/49232/#comment204706>

    You will lost the appcManifest if the AppC image has only one layer.



src/slave/containerizer/mesos/provisioner/provisioner.cpp (line 404)
<https://reviews.apache.org/r/49232/#comment204707>

    Not yours, but for windows, I think that we also do not need `imageInfo.dockerManifest`
to be here.



src/slave/containerizer/mesos/provisioner/store.hpp (line 48)
<https://reviews.apache.org/r/49232/#comment204702>

    s/Appc/AppC


- Guangya Liu


On 六月 25, 2016, 10:53 p.m., Srinivas Brahmaroutu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49232/
> -----------------------------------------------------------
> 
> (Updated 六月 25, 2016, 10:53 p.m.)
> 
> 
> Review request for mesos, Gilbert Song and Jie Yu.
> 
> 
> Bugs: MESOS-4778
>     https://issues.apache.org/jira/browse/MESOS-4778
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added appcManifest to ImageInfo and ProvisionInfo.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/containerizer.cpp d984efd4742ec084d66538c48a36ea768832324d

>   src/slave/containerizer/mesos/provisioner/appc/store.cpp aaa0efe63e587b9e604082b52a3cb8c11545fbb9

>   src/slave/containerizer/mesos/provisioner/provisioner.hpp 48a05059969e068a0ee0d38b61be9e7104e3188d

>   src/slave/containerizer/mesos/provisioner/provisioner.cpp 249acad49122d988e44744384bcf840b941c0997

>   src/slave/containerizer/mesos/provisioner/store.hpp 1d477ef13ddd24fd8badae0decaa4a2271ecc746

> 
> Diff: https://reviews.apache.org/r/49232/diff/
> 
> 
> Testing
> -------
> 
> Make Check.
> 
> 
> Thanks,
> 
> Srinivas Brahmaroutu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message