mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Anand Mazumdar <an...@apache.org>
Subject Re: Review Request 49206: Implemented GET_QUOTA Call in v1 master API.
Date Sun, 26 Jun 2016 21:08:50 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49206/#review139505
-----------------------------------------------------------



Looks good minus minor comments on style/indent.


include/mesos/master/master.proto (line 334)
<https://reviews.apache.org/r/49206/#comment204748>

    s/quota info/cluster's configured quotas.
    
    Ditto for the versioned one.



src/master/quota_handler.cpp (line 222)
<https://reviews.apache.org/r/49206/#comment204750>

    Indent off by 1 for `stringify`.



src/master/quota_handler.cpp (line 268)
<https://reviews.apache.org/r/49206/#comment204749>

    hmm .. can we move `__status` to inside the lambda itself rather than it being a separate
function?
    
    - We follow a procedural programming style and have continuation functions only when something
is waiting on a different execution context.
    - In one off cases, we move things out of a lambda when it's too long and might impact
readability. (e.g., `__set` in this file)
    
    Neithing of the above 2 seem to hold good here.



src/tests/api_tests.cpp (line 917)
<https://reviews.apache.org/r/49206/#comment204756>

    Missing backticks around set quota.



src/tests/api_tests.cpp (line 943)
<https://reviews.apache.org/r/49206/#comment204752>

    Fix the indent here. (2 spaces)
    
    Add a new line before L943



src/tests/api_tests.cpp (line 944)
<https://reviews.apache.org/r/49206/#comment204757>

    Move this comment out of the block and also add backticks.



src/tests/api_tests.cpp (line 948)
<https://reviews.apache.org/r/49206/#comment204751>

    Do this after L923 since it's common to both blocks.



src/tests/api_tests.cpp (line 958)
<https://reviews.apache.org/r/49206/#comment204755>

    Fix the indent to be right below `quotaResources`.


- Anand Mazumdar


On June 25, 2016, 9:03 a.m., Abhishek Dasgupta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49206/
> -----------------------------------------------------------
> 
> (Updated June 25, 2016, 9:03 a.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, haosdent huang, and Vinod Kone.
> 
> 
> Bugs: MESOS-5508
>     https://issues.apache.org/jira/browse/MESOS-5508
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Implemented GET_QUOTA Call in v1 master API.
> 
> 
> Diffs
> -----
> 
>   include/mesos/master/master.proto 639fbd110df4aca1cf700cb9e455eecc110a7f66 
>   include/mesos/v1/master/master.proto 11dfab318eb073908a9e302afa33b274fec63a16 
>   src/master/http.cpp ad3f723ec21dd0e9f3a3f015d4de0702625cd603 
>   src/master/master.hpp e983d1ba6ebcdaf2ace419201659e53edaa2a0aa 
>   src/master/quota_handler.cpp 4fa7533cb6a109fd060050c7814de440bd34c8ed 
>   src/tests/api_tests.cpp 7f16f43c3968cd56cf93951489079032093beaeb 
> 
> Diff: https://reviews.apache.org/r/49206/diff/
> 
> 
> Testing
> -------
> 
> On Ubuntu 16.04 :
> 
> sudo GTEST_FILTER="*MasterAPITest.GetQuota*" make -j4 check
> 
> 
> Thanks,
> 
> Abhishek Dasgupta
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message