mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From haosdent huang <haosd...@gmail.com>
Subject Re: Review Request 49245: Implement READ_FILE for agent operator API.
Date Mon, 27 Jun 2016 14:25:13 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49245/#review139572
-----------------------------------------------------------


Fix it, then Ship it!




Ship It!


src/slave/http.cpp (lines 1337 - 1347)
<https://reviews.apache.org/r/49245/#comment204823>

    Indent 2 spaces here for case/default keyword.


- haosdent huang


On June 27, 2016, 9:12 a.m., zhou xing wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49245/
> -----------------------------------------------------------
> 
> (Updated June 27, 2016, 9:12 a.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, haosdent huang, and Vinod Kone.
> 
> 
> Bugs: mesos-5515
>     https://issues.apache.org/jira/browse/mesos-5515
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Implemented readFile method for agent operator API.
> 
> 
> Diffs
> -----
> 
>   src/slave/http.cpp c038bf0c9680ec86f77f1a27efeb7354a9e67627 
>   src/slave/slave.hpp 58ff2bfac6918d989ab36b67cf6ba2f3657c8356 
>   src/tests/api_tests.cpp 7f16f43c3968cd56cf93951489079032093beaeb 
> 
> Diff: https://reviews.apache.org/r/49245/diff/
> 
> 
> Testing
> -------
> 
> make
> make check
> 
> 
> Thanks,
> 
> zhou xing
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message