mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Anand Mazumdar <an...@apache.org>
Subject Re: Review Request 49225: Implemented RESERVE_RESOURCES Call in v1 master API.
Date Mon, 27 Jun 2016 17:23:56 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49225/#review139602
-----------------------------------------------------------


Fix it, then Ship it!




LGTM minus a few suggested minor cleanups.


src/tests/api_tests.cpp (lines 93 - 99)
<https://reviews.apache.org/r/49225/#comment204853>

    Let's not duplicate this function again. Kill this and just inline this in the test itself.



src/tests/api_tests.cpp (line 513)
<https://reviews.apache.org/r/49225/#comment204854>

    s/tests/test verifies
    s/RESERVE_RESOURCES v1 API call/the `RESERVE_RESOURCES` call.



src/tests/api_tests.cpp (line 577)
<https://reviews.apache.org/r/49225/#comment204856>

    Nit: Should fit in the previous line itself.


- Anand Mazumdar


On June 27, 2016, 8:19 a.m., Abhishek Dasgupta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49225/
> -----------------------------------------------------------
> 
> (Updated June 27, 2016, 8:19 a.m.)
> 
> 
> Review request for mesos, Anand Mazumdar and Vinod Kone.
> 
> 
> Bugs: MESOS-5499
>     https://issues.apache.org/jira/browse/MESOS-5499
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Implemented RESERVE_RESOURCES Call in v1 master API.
> 
> 
> Diffs
> -----
> 
>   src/master/http.cpp d55aa05c76bb2b1fb17b795510fd50c021cdb995 
>   src/master/master.hpp 648f1a217cc7bbb154a9d7a2a8b2c5d02087af03 
>   src/tests/api_tests.cpp 7f16f43c3968cd56cf93951489079032093beaeb 
> 
> Diff: https://reviews.apache.org/r/49225/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Abhishek Dasgupta
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message