mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gilbert Song <songzihao1...@gmail.com>
Subject Re: Review Request 49208: Modified tests to check is appc spec with app object is properly parsed.
Date Mon, 27 Jun 2016 17:58:30 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49208/#review139618
-----------------------------------------------------------




src/tests/containerizer/provisioner_appc_tests.cpp (line 112)
<https://reviews.apache.org/r/49208/#comment204877>

    Srini, not yours. This is a tech debt.
    
    Since you are already on it. Could you please move the spec tests to appc_spec_test.cpp?
    
    Please follow docker_spec_test.cpp for example. Thanks.



src/tests/containerizer/provisioner_appc_tests.cpp (line 159)
<https://reviews.apache.org/r/49208/#comment204878>

    Could you verify the contents using `EXPECT_EQ(...)`?
    
    Please look at docker_spec_test.cpp for example.



src/tests/containerizer/provisioner_appc_tests.cpp (lines 605 - 617)
<https://reviews.apache.org/r/49208/#comment204874>

    I think this patch just focus on spec tests. Why do you need to modify the manifest in
fetcher test?



src/tests/containerizer/provisioner_appc_tests.cpp (lines 836 - 848)
<https://reviews.apache.org/r/49208/#comment204875>

    Ditto.


- Gilbert Song


On June 25, 2016, 10:21 a.m., Srinivas Brahmaroutu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49208/
> -----------------------------------------------------------
> 
> (Updated June 25, 2016, 10:21 a.m.)
> 
> 
> Review request for mesos, Gilbert Song and Jie Yu.
> 
> 
> Bugs: MESOS-4778
>     https://issues.apache.org/jira/browse/MESOS-4778
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Modified tests to check is appc spec with app object is properly parsed.
> 
> 
> Diffs
> -----
> 
>   src/tests/containerizer/provisioner_appc_tests.cpp 061f80c62319817b22a5c1880a4858fdafbfb72a

> 
> Diff: https://reviews.apache.org/r/49208/diff/
> 
> 
> Testing
> -------
> 
> Make check
> 
> 
> Thanks,
> 
> Srinivas Brahmaroutu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message