mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Vinod Kone <vinodk...@gmail.com>
Subject Re: Review Request 49228: Fixed wrong stopped time in webui for live tasks.
Date Mon, 27 Jun 2016 18:27:34 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49228/#review139622
-----------------------------------------------------------




src/webui/master/static/js/controllers.js (line 149)
<https://reviews.apache.org/r/49228/#comment204888>

    task.statuses[0] could be a terminal state if a task went directly from TASK_STAGING to
TASK_LOST, i.e., a task was removed before any update for it was received by the master (e.g.,
agent removed).



src/webui/master/static/js/controllers.js (lines 158 - 160)
<https://reviews.apache.org/r/49228/#comment204887>

    don't think this check belongs here. whether `task.statuses` is empty or not is unrelated
to whether a task is terminal. move this to #151
    
    ```
    if (isTaskTerminated(task) && task.statuses.length > 1) {
    
    }
    
    ```



src/webui/master/static/js/controllers.js (line 161)
<https://reviews.apache.org/r/49228/#comment204886>

    TASK_LOST and TASK_ERROR are also terminal states.


- Vinod Kone


On June 27, 2016, 5:40 p.m., Tomasz Janiszewski wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49228/
> -----------------------------------------------------------
> 
> (Updated June 27, 2016, 5:40 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler, haosdent huang, Ross Allen, and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Only set the terminal time if the last state is terminal.
> 
> 
> Diffs
> -----
> 
>   src/webui/master/static/js/controllers.js be3fa1f1fba9eda7ebcc9bf33142fe4307dd8d90

> 
> Diff: https://reviews.apache.org/r/49228/diff/
> 
> 
> Testing
> -------
> 
> Generate orpahne tasks that is alive. It should have not set stopped time.
> 
> 
> Thanks,
> 
> Tomasz Janiszewski
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message