mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Anand Mazumdar <an...@apache.org>
Subject Re: Review Request 49137: Implement v1 operator API GET_FRAMEWORK call.
Date Mon, 27 Jun 2016 20:39:44 GMT


> On June 27, 2016, 8:34 p.m., Vinod Kone wrote:
> > src/master/http.cpp, line 1261
> > <https://reviews.apache.org/r/49137/diff/4/?file=1430595#file1430595line1261>
> >
> >     @anand: i remember us discussing about evolving large responses like these?
was the idea to directly construct a v1 response instead of constructiong un-versioned response
and evolving it?

+1, yes. Should we be doing it now or do an audit later? I am fine with either of the approaches.


- Anand


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49137/#review139643
-----------------------------------------------------------


On June 27, 2016, 7:48 a.m., zhou xing wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49137/
> -----------------------------------------------------------
> 
> (Updated June 27, 2016, 7:48 a.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, haosdent huang, and Vinod Kone.
> 
> 
> Bugs: mesos-5492
>     https://issues.apache.org/jira/browse/mesos-5492
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Implemented getFrameworks method in http.cpp.
> 
> 
> Diffs
> -----
> 
>   src/master/http.cpp d55aa05c76bb2b1fb17b795510fd50c021cdb995 
>   src/master/master.hpp 648f1a217cc7bbb154a9d7a2a8b2c5d02087af03 
>   src/tests/api_tests.cpp 7f16f43c3968cd56cf93951489079032093beaeb 
> 
> Diff: https://reviews.apache.org/r/49137/diff/
> 
> 
> Testing
> -------
> 
> make
> make check
> 
> 
> Thanks,
> 
> zhou xing
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message