mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From haosdent huang <haosd...@gmail.com>
Subject Re: Review Request 49137: Implement v1 operator API GET_FRAMEWORK call.
Date Tue, 28 Jun 2016 06:21:40 GMT


> On June 27, 2016, 2:04 p.m., haosdent huang wrote:
> > src/master/http.cpp, line 1283
> > <https://reviews.apache.org/r/49137/diff/4/?file=1430595#file1430595line1283>
> >
> >     The style here looks incorrect
> 
> zhou xing wrote:
>     haosdent, any suggestions here?

Because we allow

```
    response.mutable_get_frameworks().add_unregistered_frameworks()
        .set_value(frameworkId.value());
```

so I think 

```
    response.mutable_get_frameworks().add_unregistered_frameworks()
        ->set_value(frameworkId.value());
```

is fine as well. Could ignore my comments. Sorry for make you confusing.


- haosdent


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49137/#review139571
-----------------------------------------------------------


On June 28, 2016, 3:11 a.m., zhou xing wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49137/
> -----------------------------------------------------------
> 
> (Updated June 28, 2016, 3:11 a.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, haosdent huang, and Vinod Kone.
> 
> 
> Bugs: mesos-5492
>     https://issues.apache.org/jira/browse/mesos-5492
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Implemented getFrameworks method in http.cpp.
> 
> 
> Diffs
> -----
> 
>   src/master/http.cpp 9e6d291aff77bb39462375dfed5dc75f3719806f 
>   src/master/master.hpp f16bccd0b72a8785d03290d11cd9b28d2990fd24 
>   src/tests/api_tests.cpp 7eb179f300f7a7dc6bdc3425268e7cd2fc8299fe 
> 
> Diff: https://reviews.apache.org/r/49137/diff/
> 
> 
> Testing
> -------
> 
> make
> make check
> 
> 
> Thanks,
> 
> zhou xing
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message