-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49296/#review139741
-----------------------------------------------------------
Fix it, then Ship it!
src/master/validation.cpp (line 139)
<https://reviews.apache.org/r/49296/#comment205079>
Wrap this on the previous line
```cpp
case XXX: {
}
```
Ditto for the other occurence.
src/master/validation.cpp (line 144)
<https://reviews.apache.org/r/49296/#comment205084>
s/reservationError/error
Ditto for the other occurence.
src/master/validation.cpp (line 146)
<https://reviews.apache.org/r/49296/#comment205081>
new line before
Ditto for the other occurence.
src/master/validation.cpp (line 147)
<https://reviews.apache.org/r/49296/#comment205083>
`return error;` ?
Ditto for the other occurence.
- Anand Mazumdar
On June 28, 2016, 6:23 a.m., Abhishek Dasgupta wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49296/
> -----------------------------------------------------------
>
> (Updated June 28, 2016, 6:23 a.m.)
>
>
> Review request for mesos, Anand Mazumdar and Vinod Kone.
>
>
> Bugs: MESOS-5499
> https://issues.apache.org/jira/browse/MESOS-5499
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added validation check on resources for reserve/unreserve call.
>
>
> Diffs
> -----
>
> src/master/validation.cpp 9120b71fc7725bdf7094aac6619d8aadcc352df5
>
> Diff: https://reviews.apache.org/r/49296/diff/
>
>
> Testing
> -------
>
> On Ubuntu 16.04:
>
> sudo GTEST_FILTER="*MasterAPITest.UnreserveResources*:*MasterAPITest.ReserveResources*"
make -j4 check
>
>
> Thanks,
>
> Abhishek Dasgupta
>
>
|