mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From zhou xing <xingz...@cn.ibm.com>
Subject Re: Review Request 49243: Create readFile method in FilesProcess.
Date Tue, 28 Jun 2016 11:14:05 GMT


> On 六月 27, 2016, 2:43 p.m., haosdent huang wrote:
> > src/files/files.hpp, lines 70-73
> > <https://reviews.apache.org/r/49243/diff/1/?file=1430573#file1430573line70>
> >
> >     Refert to
> >     ```
> >     class ErrnoError : public Error
> >     {
> >     public:
> >       ErrnoError() : Error(os::strerror(errno)), code(errno) {}
> >     
> >       ErrnoError(const std::string& message)
> >         : Error(message + ": " + os::strerror(errno)), code(errno) {}
> >     
> >       const int code;
> >     };
> >     ```
> >     
> >     Maybe we coud use `FilesError(Type _type)` and `FilesError(Type _type, std::string
_message)`?

please refer to https://reviews.apache.org/r/49301/


- zhou


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49243/#review139575
-----------------------------------------------------------


On 六月 28, 2016, 11:13 a.m., zhou xing wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49243/
> -----------------------------------------------------------
> 
> (Updated 六月 28, 2016, 11:13 a.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, haosdent huang, and Vinod Kone.
> 
> 
> Bugs: mesos-5515
>     https://issues.apache.org/jira/browse/mesos-5515
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This method helps to readFiles based on offset, length
> and path, which can be used for implementing master/agent's
> READ_FILE operator v1 API.
> 
> 
> Diffs
> -----
> 
>   src/files/files.hpp b767d5bc5bee16e3bd98199773a6bc7d30c1c32d 
>   src/files/files.cpp a5a1b86e14f63e5e3834a2900270252fbe16f586 
> 
> Diff: https://reviews.apache.org/r/49243/diff/
> 
> 
> Testing
> -------
> 
> make
> make check
> 
> 
> Thanks,
> 
> zhou xing
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message