mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Guangya Liu <gyliu...@gmail.com>
Subject Re: Review Request 49219: Added runtime isolator interface to run appc containers.
Date Tue, 28 Jun 2016 13:49:37 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49219/#review139782
-----------------------------------------------------------




src/slave/containerizer/mesos/isolators/appc/runtime.cpp (line 51)
<https://reviews.apache.org/r/49219/#comment205130>

    Please keep two lines between each two function and ditto for the following.



src/slave/containerizer/mesos/isolators/appc/runtime.cpp (line 77)
<https://reviews.apache.org/r/49219/#comment205128>

    Period to the end
    s/appc/AppC


- Guangya Liu


On 六月 28, 2016, 5:54 a.m., Srinivas Brahmaroutu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49219/
> -----------------------------------------------------------
> 
> (Updated 六月 28, 2016, 5:54 a.m.)
> 
> 
> Review request for mesos, Gilbert Song and Jie Yu.
> 
> 
> Bugs: MESOS-4778
>     https://issues.apache.org/jira/browse/MESOS-4778
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added runtime isolator interface to run appc containers.
> 
> 
> Diffs
> -----
> 
>   src/CMakeLists.txt ecdeee75abfca944bc2ac1da4962d8d50e236d2d 
>   src/Makefile.am 23cac95a805e46d216e9479fea09f2c1619c45a5 
>   src/slave/containerizer/mesos/isolators/appc/runtime.hpp PRE-CREATION 
>   src/slave/containerizer/mesos/isolators/appc/runtime.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/49219/diff/
> 
> 
> Testing
> -------
> 
> Make Check
> 
> 
> Thanks,
> 
> Srinivas Brahmaroutu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message