mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Guangya Liu <gyliu...@gmail.com>
Subject Re: Review Request 49232: Added appcManifest to ImageInfo and ProvisionInfo.
Date Tue, 28 Jun 2016 15:38:59 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49232/#review139806
-----------------------------------------------------------




include/mesos/appc/spec.proto 
<https://reviews.apache.org/r/49232/#comment205156>

    This comment should be addressed in https://reviews.apache.org/r/49207/
    
    I saw that you fixed some commentes for other patches, it is better address the comments
in the original patch.
    
    Ditto for the update of include/mesos/slave/isolator.proto.



src/slave/containerizer/mesos/containerizer.cpp (line 317)
<https://reviews.apache.org/r/49232/#comment205152>

    Put `appc/runtime` above `docker/runtime`?



src/slave/containerizer/mesos/provisioner/appc/store.cpp (lines 212 - 213)
<https://reviews.apache.org/r/49232/#comment205153>

    VLOG(1) << "Failed to get manifest for AppC image  '"
            << appc.SerializeAsString() << "'";
            
    Please make sure the `<<` keep aligned.



src/slave/containerizer/mesos/provisioner/provisioner.cpp (lines 334 - 335)
<https://reviews.apache.org/r/49232/#comment205154>

    Can we simplify the logic as:
    
    if (imageInfo.layers.size() == 1) {
      return ProvisionInfo{
        rootfs, imageInfo.dockerManifest, imageInfo.appcManifest};
    }



src/slave/containerizer/mesos/provisioner/provisioner.cpp (lines 403 - 404)
<https://reviews.apache.org/r/49232/#comment205155>

    What about 
    
    return ProvisionInfo{
      rootfs, imageInfo.dockerManifest, imageInfo.appcManifest};


- Guangya Liu


On 六月 28, 2016, 6:39 a.m., Srinivas Brahmaroutu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49232/
> -----------------------------------------------------------
> 
> (Updated 六月 28, 2016, 6:39 a.m.)
> 
> 
> Review request for mesos, Gilbert Song and Jie Yu.
> 
> 
> Bugs: MESOS-4778
>     https://issues.apache.org/jira/browse/MESOS-4778
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added appcManifest to ImageInfo and ProvisionInfo.
> 
> 
> Diffs
> -----
> 
>   include/mesos/appc/spec.proto 4ef0473748c2f47aff1729c1d969185803fe72d4 
>   include/mesos/slave/isolator.proto f17a3a4f167eb203709d7ebac3ade220ac8641ea 
>   src/slave/containerizer/mesos/containerizer.cpp d984efd4742ec084d66538c48a36ea768832324d

>   src/slave/containerizer/mesos/provisioner/appc/store.cpp aaa0efe63e587b9e604082b52a3cb8c11545fbb9

>   src/slave/containerizer/mesos/provisioner/provisioner.hpp 48a05059969e068a0ee0d38b61be9e7104e3188d

>   src/slave/containerizer/mesos/provisioner/provisioner.cpp 249acad49122d988e44744384bcf840b941c0997

>   src/slave/containerizer/mesos/provisioner/store.hpp 1d477ef13ddd24fd8badae0decaa4a2271ecc746

> 
> Diff: https://reviews.apache.org/r/49232/diff/
> 
> 
> Testing
> -------
> 
> Make Check.
> 
> 
> Thanks,
> 
> Srinivas Brahmaroutu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message