mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jie Yu <yujie....@gmail.com>
Subject Review Request 49341: Simplified setsid logic in command executor.
Date Tue, 28 Jun 2016 22:14:27 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49341/
-----------------------------------------------------------

Review request for mesos, Benjamin Mahler, Gilbert Song, and Ian Downes.


Repository: mesos


Description
-------

The setsid loop is not necessary. POSIX standard suggests that the pid
of the child should not be equal to any active process group id.


Diffs
-----

  src/launcher/posix/executor.cpp b393db6c0631b5b5c43fb4d3d9183d9100e31049 

Diff: https://reviews.apache.org/r/49341/diff/


Testing
-------


Thanks,

Jie Yu


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message