mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From zhou xing <xingz...@cn.ibm.com>
Subject Re: Review Request 49243: Create readFile method in FilesProcess.
Date Thu, 30 Jun 2016 06:59:59 GMT


> On 六月 27, 2016, 2:43 p.m., haosdent huang wrote:
> > src/files/files.cpp, lines 85-87
> > <https://reviews.apache.org/r/49243/diff/1/?file=1430574#file1430574line85>
> >
> >     Why move these lines?
> 
> zhou xing wrote:
>     in files.hpp, I included  '#include "mesos/mesos.hpp"' to use mesos::FileContent
object, this include will lead to some compile error like:
>     ''' 
>     ../../src/files/files.cpp:343:33: error: no member named 'url' in
>           'mesos::Request'
>     ''
>     So I moved this to using clause inside the namespace declaration.

moved it back to original place


- zhou


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49243/#review139575
-----------------------------------------------------------


On 六月 30, 2016, 6:59 a.m., zhou xing wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49243/
> -----------------------------------------------------------
> 
> (Updated 六月 30, 2016, 6:59 a.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, haosdent huang, and Vinod Kone.
> 
> 
> Bugs: mesos-5515
>     https://issues.apache.org/jira/browse/mesos-5515
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This method helps to readFiles based on offset, length
> and path, which can be used for implementing master/agent's
> READ_FILE operator v1 API.
> 
> 
> Diffs
> -----
> 
>   src/files/files.hpp b767d5bc5bee16e3bd98199773a6bc7d30c1c32d 
>   src/files/files.cpp a5a1b86e14f63e5e3834a2900270252fbe16f586 
> 
> Diff: https://reviews.apache.org/r/49243/diff/
> 
> 
> Testing
> -------
> 
> make
> make check
> 
> 
> Thanks,
> 
> zhou xing
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message