From reviews-return-36485-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Mon Jun 13 03:25:40 2016 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id AC2CD19494 for ; Mon, 13 Jun 2016 03:25:40 +0000 (UTC) Received: (qmail 74944 invoked by uid 500); 13 Jun 2016 03:25:40 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 74913 invoked by uid 500); 13 Jun 2016 03:25:40 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 74892 invoked by uid 99); 13 Jun 2016 03:25:40 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 13 Jun 2016 03:25:40 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 9B8F02C54CF; Mon, 13 Jun 2016 03:25:39 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============7446720823439818187==" MIME-Version: 1.0 Subject: Re: Review Request 48604: Implemented docker spec helper to parse URL. From: Jie Yu To: Timothy Chen , Jie Yu , Artem Harutyunyan , Guangya Liu Cc: Gilbert Song , mesos Date: Mon, 13 Jun 2016 03:25:39 -0000 Message-ID: <20160613032539.30691.96736@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Jie Yu X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/48604/ X-Sender: Jie Yu X-ReviewBoard-ShipIt: 1 References: <20160612190738.30691.42238@reviews.apache.org> In-Reply-To: <20160612190738.30691.42238@reviews.apache.org> Reply-To: Jie Yu X-ReviewRequest-Repository: mesos --===============7446720823439818187== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48604/#review137218 ----------------------------------------------------------- Fix it, then Ship it! include/mesos/docker/spec.hpp (line 83) I would rename this to parseAuthConfig as well. Can you followup with a patch to do the renaming? include/mesos/docker/spec.hpp (line 89) parseUrl sounds too general. s/parseUrl/parseAuthUrl/ - Jie Yu On June 12, 2016, 7:07 p.m., Gilbert Song wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48604/ > ----------------------------------------------------------- > > (Updated June 12, 2016, 7:07 p.m.) > > > Review request for mesos, Guangya Liu, Artem Harutyunyan, Jie Yu, and Timothy Chen. > > > Bugs: MESOS-4938 > https://issues.apache.org/jira/browse/MESOS-4938 > > > Repository: mesos > > > Description > ------- > > Implemented docker spec helper to parse URL. > > > Diffs > ----- > > include/mesos/docker/spec.hpp b37c7731590ec144df720d7b28eeed5db76f750e > src/docker/spec.cpp 7270d182b8c3a5d5c34cbda2bd736ba489089720 > > Diff: https://reviews.apache.org/r/48604/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Gilbert Song > > --===============7446720823439818187==--