From reviews-return-37172-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Fri Jun 17 20:36:23 2016 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id D46EE19C31 for ; Fri, 17 Jun 2016 20:36:23 +0000 (UTC) Received: (qmail 35046 invoked by uid 500); 17 Jun 2016 20:36:23 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 35018 invoked by uid 500); 17 Jun 2016 20:36:23 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 35003 invoked by uid 99); 17 Jun 2016 20:36:23 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 17 Jun 2016 20:36:23 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 6A5D62CE2DB; Fri, 17 Jun 2016 20:36:22 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============5472840819584599954==" MIME-Version: 1.0 Subject: Re: Review Request 46875: Some cleanup in weights_handler.cpp. From: Adam B To: Adam B , Alexander Rukletsov Cc: Guangya Liu , mesos Date: Fri, 17 Jun 2016 20:36:22 -0000 Message-ID: <20160617203622.4742.55461@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Adam B X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/46875/ X-Sender: Adam B X-ReviewBoard-ShipIt: 1 References: <20160501065242.19046.48985@reviews.apache.org> In-Reply-To: <20160501065242.19046.48985@reviews.apache.org> X-ReviewBoard-ShipIt-Only: 1 Reply-To: Adam B X-ReviewRequest-Repository: mesos --===============5472840819584599954== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46875/#review138309 ----------------------------------------------------------- Ship it! Ship It! - Adam B On April 30, 2016, 11:52 p.m., Guangya Liu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46875/ > ----------------------------------------------------------- > > (Updated April 30, 2016, 11:52 p.m.) > > > Review request for mesos, Adam B and Alexander Rukletsov. > > > Repository: mesos > > > Description > ------- > > There is no need to add () for request body as there is already > '' for the message. > > > Diffs > ----- > > src/master/weights_handler.cpp 07cc9920ca61f3e6e9e5b8be37884ed6f0d4f975 > > Diff: https://reviews.apache.org/r/46875/diff/ > > > Testing > ------- > > Before fix: > root@mesos002:~/test# curl -d weight.json -X PUT http://192.168.56.12:5050/weights > Failed to parse update weights request JSON ('weight.json'): syntax error at line 1 near: weight.js > > After fix: > root@mesos002:~/test# curl -d weight.json -X PUT http://192.168.56.12:5050/weights > Failed to parse update weights request JSON 'weight.json': syntax error at line 1 near: weight.json > > > Thanks, > > Guangya Liu > > --===============5472840819584599954==--