From reviews-return-37290-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Sat Jun 18 17:11:10 2016 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id E95BE184D6 for ; Sat, 18 Jun 2016 17:11:10 +0000 (UTC) Received: (qmail 60381 invoked by uid 500); 18 Jun 2016 17:11:10 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 60353 invoked by uid 500); 18 Jun 2016 17:11:10 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 60333 invoked by uid 99); 18 Jun 2016 17:11:10 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 18 Jun 2016 17:11:10 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 61AC91DB68C; Sat, 18 Jun 2016 17:11:09 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============6243729608124075348==" MIME-Version: 1.0 Subject: Re: Review Request 48268: Implemented SET_QUOTA Call in v1 master API. From: haosdent huang To: Anand Mazumdar , Vinod Kone Cc: Mesos ReviewBot , Abhishek Dasgupta , haosdent huang , mesos Date: Sat, 18 Jun 2016 17:11:09 -0000 Message-ID: <20160618171109.4742.99017@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: haosdent huang X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/48268/ X-Sender: haosdent huang References: <20160617063642.4742.88814@reviews.apache.org> In-Reply-To: <20160617063642.4742.88814@reviews.apache.org> X-ReviewBoard-Diff-For: include/mesos/v1/quota/quota.hpp Reply-To: haosdent huang X-ReviewRequest-Repository: mesos --===============6243729608124075348== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit > On June 17, 2016, 6:36 a.m., haosdent huang wrote: > > src/internal/devolve.hpp, line 28 > > > > > > Put this above > > ``` > > #include > > ``` I think the alphabectial should be `opq rst`. So ``` #include #include #include ``` should change to ``` #include #include #include ``` right? - haosdent ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48268/#review138170 ----------------------------------------------------------- On June 18, 2016, 2:53 p.m., Abhishek Dasgupta wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48268/ > ----------------------------------------------------------- > > (Updated June 18, 2016, 2:53 p.m.) > > > Review request for mesos, Anand Mazumdar and Vinod Kone. > > > Bugs: MESOS-5509 > https://issues.apache.org/jira/browse/MESOS-5509 > > > Repository: mesos > > > Description > ------- > > Implemented SET_QUOTA Call in v1 master API. > > > Diffs > ----- > > include/mesos/v1/master/master.proto 59e978fef6e0faca7dc8c25b47a79f0b5007d0a6 > include/mesos/v1/quota/quota.hpp PRE-CREATION > src/Makefile.am a4931560f1a5b3fbe41ea181477341d3ac459b58 > src/internal/devolve.hpp 4a6ae681d37b3405ee81c4a58388b8d501743ebf > src/master/http.cpp a6beb1721958a77886f0aa535346e2ff33bd5d04 > src/master/master.hpp 618d928ef1398e7397df968c7cd47acbc987d1e3 > src/master/quota_handler.cpp 567f1c2cc59b859227a8b48c6086ce3f8049f14d > src/tests/api_tests.cpp afa5ffab8729dfc5b102968ec64c6a3bcd832dfd > > Diff: https://reviews.apache.org/r/48268/diff/ > > > Testing > ------- > > On Ubuntu 16.04: > sudo GTEST_FILTER="*MasterAPITest.SetQuota*" make -j4 check > > [==========] Running 2 tests from 1 test case. > [----------] Global test environment set-up. > [----------] 2 tests from ContentType/MasterAPITest > [ RUN ] ContentType/MasterAPITest.SetQuota/0 > [ OK ] ContentType/MasterAPITest.SetQuota/0 (129 ms) > [ RUN ] ContentType/MasterAPITest.SetQuota/1 > [ OK ] ContentType/MasterAPITest.SetQuota/1 (98 ms) > [----------] 2 tests from ContentType/MasterAPITest (227 ms total) > > [----------] Global test environment tear-down > [==========] 2 tests from 1 test case ran. (236 ms total) > [ PASSED ] 2 tests. > > > Thanks, > > Abhishek Dasgupta > > --===============6243729608124075348==--