From reviews-return-38492-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Tue Jun 28 16:56:57 2016 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id DFA6B19CE0 for ; Tue, 28 Jun 2016 16:56:56 +0000 (UTC) Received: (qmail 88003 invoked by uid 500); 28 Jun 2016 16:56:56 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 87974 invoked by uid 500); 28 Jun 2016 16:56:56 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 87954 invoked by uid 99); 28 Jun 2016 16:56:56 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 28 Jun 2016 16:56:56 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 19CA22BD2CF; Tue, 28 Jun 2016 16:56:56 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============6871373277070996707==" MIME-Version: 1.0 Subject: Re: Review Request 49247: Implemented REMOVE_QUOTA Call in v1 master API. From: Abhishek Dasgupta To: Anand Mazumdar , Vinod Kone , haosdent huang Cc: Mesos ReviewBot , Abhishek Dasgupta , mesos Date: Tue, 28 Jun 2016 16:56:56 -0000 Message-ID: <20160628165656.1635.28270@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Abhishek Dasgupta X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/49247/ X-Sender: Abhishek Dasgupta References: <20160628161355.1634.616@reviews.apache.org> In-Reply-To: <20160628161355.1634.616@reviews.apache.org> Reply-To: Abhishek Dasgupta X-ReviewRequest-Repository: mesos --===============6871373277070996707== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49247/ ----------------------------------------------------------- (Updated June 28, 2016, 4:56 p.m.) Review request for mesos, Anand Mazumdar, haosdent huang, and Vinod Kone. Bugs: MESOS-5510 https://issues.apache.org/jira/browse/MESOS-5510 Repository: mesos Description ------- Implemented REMOVE_QUOTA Call in v1 master API. Diffs (updated) ----- src/master/http.cpp 9e6d291aff77bb39462375dfed5dc75f3719806f src/master/master.hpp f16bccd0b72a8785d03290d11cd9b28d2990fd24 src/master/quota_handler.cpp 4fa7533cb6a109fd060050c7814de440bd34c8ed src/tests/api_tests.cpp 7eb179f300f7a7dc6bdc3425268e7cd2fc8299fe Diff: https://reviews.apache.org/r/49247/diff/ Testing ------- On Ubuntu 16.04 : sudo GTEST_FILTER="*MasterAPITest.RemoveQuota*" make -j4 check Thanks, Abhishek Dasgupta --===============6871373277070996707==--