From reviews-return-38503-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Tue Jun 28 18:51:24 2016 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 5FB2019120 for ; Tue, 28 Jun 2016 18:51:24 +0000 (UTC) Received: (qmail 75451 invoked by uid 500); 28 Jun 2016 18:51:24 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 75422 invoked by uid 500); 28 Jun 2016 18:51:24 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 75405 invoked by uid 99); 28 Jun 2016 18:51:23 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 28 Jun 2016 18:51:23 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id BF4642BD343; Tue, 28 Jun 2016 18:51:23 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============3938732855254616521==" MIME-Version: 1.0 Subject: Re: Review Request 46687: Updated `dispatch` calls to use lambda in http_tests.cpp. From: haosdent huang To: Kevin Klues , Michael Park Cc: Mesos ReviewBot , haosdent huang , mesos Date: Tue, 28 Jun 2016 18:51:23 -0000 Message-ID: <20160628185123.1634.44032@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: haosdent huang X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/46687/ X-Sender: haosdent huang References: <20160626073727.24740.99090@reviews.apache.org> In-Reply-To: <20160626073727.24740.99090@reviews.apache.org> Reply-To: haosdent huang X-ReviewRequest-Repository: mesos --===============3938732855254616521== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit > On June 26, 2016, 7:37 a.m., Michael Park wrote: > > Could you specify that this only updates `http_tests.cpp`? There are other places in the codebase where we explicitly construct a `std::function` first, but we don't update all of those in this patch. > > Michael Park wrote: > Just in the summary and/or description, that is. Hi, @mcypark Thanks a lot for your detail comments. I found the remain legacy codes are only exists in `deferred.hpp`. I post a sperate patch in https://reviews.apache.org/r/49315/ - haosdent ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46687/#review139483 ----------------------------------------------------------- On June 28, 2016, 9:43 a.m., haosdent huang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46687/ > ----------------------------------------------------------- > > (Updated June 28, 2016, 9:43 a.m.) > > > Review request for mesos, Kevin Klues and Michael Park. > > > Bugs: MESOS-4611 > https://issues.apache.org/jira/browse/MESOS-4611 > > > Repository: mesos > > > Description > ------- > > Updated `dispatch` calls to use lambda in http_tests.cpp. > > > Diffs > ----- > > 3rdparty/libprocess/src/tests/http_tests.cpp 4337e6028a3a6e5279793c7c6f73bb9a4f60cb0a > > Diff: https://reviews.apache.org/r/46687/diff/ > > > Testing > ------- > > > Thanks, > > haosdent huang > > --===============3938732855254616521==--