From reviews-return-38542-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Tue Jun 28 22:57:39 2016 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 9510919A7C for ; Tue, 28 Jun 2016 22:57:39 +0000 (UTC) Received: (qmail 19384 invoked by uid 500); 28 Jun 2016 22:57:39 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 19357 invoked by uid 500); 28 Jun 2016 22:57:39 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 19325 invoked by uid 99); 28 Jun 2016 22:57:39 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 28 Jun 2016 22:57:39 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id CE87F2BD3CA; Tue, 28 Jun 2016 22:50:07 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============1474209285851813126==" MIME-Version: 1.0 Subject: Re: Review Request 49321: GetState response protobuf. From: Zhitao Li To: Anand Mazumdar , zhou xing , Vinod Kone , haosdent huang Cc: Zhitao Li , mesos Date: Tue, 28 Jun 2016 22:50:07 -0000 Message-ID: <20160628225007.1635.49595@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Zhitao Li X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/49321/ X-Sender: Zhitao Li References: <20160628150732.1635.84670@reviews.apache.org> In-Reply-To: <20160628150732.1635.84670@reviews.apache.org> Reply-To: Zhitao Li X-ReviewRequest-Repository: mesos --===============1474209285851813126== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49321/#review139887 ----------------------------------------------------------- include/mesos/master/master.proto (line 282) Can elected_time actually be optional? Assuming we only serve from elected leader or error out in response, this could be required to be consistent with other fields. It remains a question whether we want to make `GetFrameworks get_frameworks` optional: making it required might make future implementation of filters difficult, depending on how filters will be implemented. include/mesos/master/master.proto (lines 283 - 284) I still prefer the approach in current patch because it makes it clear that `GetState` is just composed with other `Get*` responses, and there should be no symantic or behavior difference (e.g. authorization, filter, etc). It seems like `orphan_tasks` are only reported in `GetState` but no other calls right now. Maybe we should consider add that, to be consistent with other calls? include/mesos/v1/master/master.proto (line 283) See comments above. - Zhitao Li On June 28, 2016, 3:07 p.m., Zhitao Li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49321/ > ----------------------------------------------------------- > > (Updated June 28, 2016, 3:07 p.m.) > > > Review request for mesos, Anand Mazumdar, zhou xing, haosdent huang, and Vinod Kone. > > > Bugs: MESOS-5489 > https://issues.apache.org/jira/browse/MESOS-5489 > > > Repository: mesos > > > Description > ------- > > GetState response protobuf. > > > Diffs > ----- > > include/mesos/master/master.proto 332261918a069f4e581bfc4d0fc14ce8c86c2617 > include/mesos/v1/master/master.proto 681ea1e638777059a6bf792435cbe526bc252f7a > > Diff: https://reviews.apache.org/r/49321/diff/ > > > Testing > ------- > > `make` on Mac > > > Thanks, > > Zhitao Li > > --===============1474209285851813126==--