mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Mahler <bmah...@apache.org>
Subject Re: Review Request 48908: Added test case for exclude resources from sorter.
Date Fri, 01 Jul 2016 00:45:17 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48908/#review140280
-----------------------------------------------------------


Fix it, then Ship it!





src/tests/hierarchical_allocator_tests.cpp (line 494)
<https://reviews.apache.org/r/48908/#comment205652>

    How about:
    
    ```
    DRFWithFairnessExclusion
    ```



src/tests/hierarchical_allocator_tests.cpp (line 520)
<https://reviews.apache.org/r/48908/#comment205649>

    `s/.get()./->/`



src/tests/hierarchical_allocator_tests.cpp (line 530)
<https://reviews.apache.org/r/48908/#comment205650>

    How about we be a bit more explicit that gpus are ignored?
    
    ```
      //   framework1 share = 0.33 (cpus=2, mem=1024 + ignored (gpus=1)
    
    ```



src/tests/hierarchical_allocator_tests.cpp (lines 2878 - 2879)
<https://reviews.apache.org/r/48908/#comment205655>

    How about:
    
    ```
    // Verifies that per-role dominant share metrics are correctly
    // reported when resources are excluded from fair sharing.
    ```



src/tests/hierarchical_allocator_tests.cpp (line 2880)
<https://reviews.apache.org/r/48908/#comment205654>

    How about:
    
    ```
    DominantShareMetricsWithFairnessExclusion
    ```



src/tests/hierarchical_allocator_tests.cpp (lines 2918 - 2919)
<https://reviews.apache.org/r/48908/#comment205656>

    Let's be a bit more explicit about the gpus here:
    
    ```
      // Add a second, identical agent. Now `framework2` will
      // receive an offer since it has the lowest dominant share:
      // the 100% of `gpus` allocated to framework1 are excluded!
    ```



src/tests/hierarchical_allocator_tests.cpp (lines 2932 - 2944)
<https://reviews.apache.org/r/48908/#comment205657>

    No need for this last piece, since we only care in this test about the gpu exclusion and
you've already verified that.


- Benjamin Mahler


On June 30, 2016, 7:59 a.m., Guangya Liu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48908/
> -----------------------------------------------------------
> 
> (Updated June 30, 2016, 7:59 a.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Bugs: MESOS-5623
>     https://issues.apache.org/jira/browse/MESOS-5623
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added test case for exclude resources from sorter.
> 
> 
> Diffs
> -----
> 
>   src/tests/hierarchical_allocator_tests.cpp eb11ff6b1b7bce291f336a199e8700be0bdc61c1

> 
> Diff: https://reviews.apache.org/r/48908/diff/
> 
> 
> Testing
> -------
> 
> make
> make check
> 
> [==========] Running 1 test from 1 test case.
> [----------] Global test environment set-up.
> [----------] 1 test from HierarchicalAllocatorTest
> [ RUN      ] HierarchicalAllocatorTest.DRFWithExcludeResources
> [       OK ] HierarchicalAllocatorTest.DRFWithExcludeResources (59 ms)
> [----------] 1 test from HierarchicalAllocatorTest (59 ms total)
> 
> [----------] Global test environment tear-down
> [==========] 1 test from 1 test case ran. (76 ms total)
> [  PASSED  ] 1 test.
> 
> [==========] Running 1 test from 1 test case.
> [----------] Global test environment set-up.
> [----------] 1 test from HierarchicalAllocatorTest
> [ RUN      ] HierarchicalAllocatorTest.DominantShareMetricsWithExcludeResources
> [       OK ] HierarchicalAllocatorTest.DominantShareMetricsWithExcludeResources (129
ms)
> [----------] 1 test from HierarchicalAllocatorTest (129 ms total)
> 
> [----------] Global test environment tear-down
> [==========] 1 test from 1 test case ran. (147 ms total)
> [  PASSED  ] 1 test.
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message