mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Till Toenshoff <toensh...@me.com>
Subject Re: Review Request 49400: Extended utilities to render certificate extension for IP.
Date Fri, 01 Jul 2016 00:49:17 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49400/
-----------------------------------------------------------

(Updated July 1, 2016, 12:49 a.m.)


Review request for mesos, Adam B, Albert Strasheim, Artem Harutyunyan, Joris Van Remoortere,
and Lukas Loesche.


Bugs: MESOS-5724
    https://issues.apache.org/jira/browse/MESOS-5724


Repository: mesos


Description
-------

Adds the ability to render a subject alternative name based on a given
IP address within a X509 certificate extension. Additionally the
libprocess test suite makes use of this feature.


Diffs (updated)
-----

  3rdparty/libprocess/include/process/ssl/gtest.hpp 5435ddda1fd7dfcff1a0b28f2abe35feb707ceeb

  3rdparty/libprocess/include/process/ssl/utilities.hpp ad9ec5df9d3c3e46c775ac470bce92c5cb983b8f

  3rdparty/libprocess/src/ssl/utilities.cpp d23f462b667b5d76c9323520000aa4eda2f58b1d 

Diff: https://reviews.apache.org/r/49400/diff/


Testing
-------

make check on OSX and various linux distros.

Functional testing by validating a rendered certificate;

```
openssl x509 -text -noout -in "temp_cert_file_name"
```


Thanks,

Till Toenshoff


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message