mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Zhitao Li <zhitaoli...@gmail.com>
Subject Re: Review Request 47973: Updated gc to prevent early exit in case of error.
Date Fri, 01 Jul 2016 01:50:54 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47973/#review140290
-----------------------------------------------------------




src/tests/gc_tests.cpp (line 42)
<https://reviews.apache.org/r/47973/#comment205668>

    This should also be guarded by `#ifdef __linux__`


- Zhitao Li


On June 23, 2016, 5:32 p.m., Megha Sharma wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47973/
> -----------------------------------------------------------
> 
> (Updated June 23, 2016, 5:32 p.m.)
> 
> 
> Review request for mesos and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-5196
>     https://issues.apache.org/jira/browse/MESOS-5196
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> It's possible for tasks and isolators to lay down files that are not
> deletable by GC. In the face of such errors GC needs to free up disk
> space wherever it can because it's already re-offered to frameworks.
> 
> 
> Diffs
> -----
> 
>   src/slave/gc.cpp eedb8ca713d7f5195055bb6417f03ab70731af97 
>   src/tests/gc_tests.cpp 4cb7c2f612984f7f5a9378a7f972f2438bbf28c5 
> 
> Diff: https://reviews.apache.org/r/47973/diff/
> 
> 
> Testing
> -------
> 
> Testing done with 'make check'.
> 
> 
> Thanks,
> 
> Megha Sharma
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message