mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Guangya Liu <gyliu...@gmail.com>
Subject Re: Review Request 49348: Added basic test to invoke Appc Runtime Isolator.
Date Fri, 01 Jul 2016 07:30:51 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49348/#review140315
-----------------------------------------------------------



I think that this patch should be created after the function patches finished.


src/tests/containerizer/provisioner_appc_tests.cpp (line 865)
<https://reviews.apache.org/r/49348/#comment205702>

    two lines



src/tests/containerizer/provisioner_appc_tests.cpp (line 866)
<https://reviews.apache.org/r/49348/#comment205703>

    I think there is no need to add such a test case, you can add some test cases once all
of your function patches are finished.


- Guangya Liu


On 六月 30, 2016, 6:01 a.m., Srinivas Brahmaroutu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49348/
> -----------------------------------------------------------
> 
> (Updated 六月 30, 2016, 6:01 a.m.)
> 
> 
> Review request for mesos.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added basic test to invoke Appc Runtime Isolator.
> 
> 
> Diffs
> -----
> 
>   src/tests/containerizer/provisioner_appc_tests.cpp 061f80c62319817b22a5c1880a4858fdafbfb72a

> 
> Diff: https://reviews.apache.org/r/49348/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Srinivas Brahmaroutu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message