mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Neil Conway <neil.con...@gmail.com>
Subject Review Request 49503: Fixed usage of some GMock expectations.
Date Fri, 01 Jul 2016 10:12:19 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49503/
-----------------------------------------------------------

Review request for mesos and Michael Park.


Repository: mesos


Description
-------

EXPECT_CALL() should be invoked before the event that is expected to
occur. In a few places, EXPECT_CALL() was used in a way that might
theoretically race with the generation of the expected event.


Diffs
-----

  src/tests/fault_tolerance_tests.cpp 57b1503f508304412b3d247f6ff7d5e49756fc57 
  src/tests/master_tests.cpp ddbab7a64ffac9bc706f17e8feb4b27a75ef97b0 
  src/tests/persistent_volume_tests.cpp 5125a8da44759d1235fddac26e9eb5436c3d037b 
  src/tests/scheduler_event_call_tests.cpp 2e46f2752a35d32ec805025f86954d6900060022 
  src/tests/slave_recovery_tests.cpp 8e9254afcf798d5158ec8a2c2b4cddfe50fac3f1 

Diff: https://reviews.apache.org/r/49503/diff/


Testing
-------

make check


Thanks,

Neil Conway


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message