mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos ReviewBot <revi...@mesos.apache.org>
Subject Re: Review Request 49469: Added new utility function, `frameworkHasCapability()`.
Date Fri, 01 Jul 2016 18:12:19 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49469/#review140393
-----------------------------------------------------------



Patch looks great!

Reviews applied: [49469]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose'
ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On July 1, 2016, 10:59 a.m., Neil Conway wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49469/
> -----------------------------------------------------------
> 
> (Updated July 1, 2016, 10:59 a.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Replace various hand-coded loops checking for capabilities with calls to
> this new function instead.
> 
> 
> Diffs
> -----
> 
>   src/common/protobuf_utils.hpp 3dd03da3fea10a01aa4508f53c5d1ebcc3d6a2a4 
>   src/common/protobuf_utils.cpp 040bdf82134289f0caf63e11c2ce8e7853a392b3 
>   src/docker/executor.cpp 88b7fc4c36ed3974ac6b103a29e1d975619f0c69 
>   src/launcher/executor.cpp bb88a4570d183d22dff65f6e220d566c0924001a 
>   src/master/allocator/mesos/hierarchical.cpp 38381237fa6ceb3f21fd0d4b07d7c3787f0129df

> 
> Diff: https://reviews.apache.org/r/49469/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Neil Conway
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message