mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Vinod Kone <vinodk...@gmail.com>
Subject Re: Review Request 49369: Introduced authorization based filtering for /roles.
Date Sun, 03 Jul 2016 17:25:59 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49369/#review140561
-----------------------------------------------------------


Ship it!




Ship It!

- Vinod Kone


On July 1, 2016, 2:39 p.m., Joerg Schad wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49369/
> -----------------------------------------------------------
> 
> (Updated July 1, 2016, 2:39 p.m.)
> 
> 
> Review request for mesos, Adam B and Vinod Kone.
> 
> 
> Bugs: MESOS-5709
>     https://issues.apache.org/jira/browse/MESOS-5709
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Previously only /weights was filtered but /roles actually
> contains the same information and hence both endpoints
> should be filtered in the same way.
> As part of this work we renamed the GetWeight action to
> ViewRole (and same for the acls).
> 
> 
> Diffs
> -----
> 
>   include/mesos/authorizer/acls.proto 31d5c144f92749d685dbf75b65362bd633c54ea5 
>   include/mesos/authorizer/authorizer.proto e22d3a491e0c5e7c384af8635a7f555e2194b939

>   src/authorizer/local/authorizer.cpp aadb7f6f0889514060744a7eca96cda00639eb4e 
>   src/common/http.hpp eb2d0156550b3ed90c7f72a2e1405efc45eab78a 
>   src/common/http.cpp 2ef264fc886be50d2091dbe24ab422c818b5ee0b 
>   src/master/http.cpp 528f01f2e00ddbd15da1cc4fca27b5347c9fc798 
>   src/master/weights_handler.cpp 5fc69c6a1c2663bad1774d9376b0aa9f90fa7275 
>   src/tests/authorization_tests.cpp c1e8ea64bb9008163ae8f0488306687d0f63a527 
>   src/tests/dynamic_weights_tests.cpp c67ed75a050b9db5575ac2bb6100bcf01cfc04ff 
>   src/tests/master_authorization_tests.cpp 0807469763b14f39b594769341d5eb9678d26946 
> 
> Diff: https://reviews.apache.org/r/49369/diff/
> 
> 
> Testing
> -------
> 
> sudo make check
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message