mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gilbert Song <songzihao1...@gmail.com>
Subject Re: Review Request 49348: Added implementation to Appc Runtime Isolator.
Date Mon, 11 Jul 2016 20:28:28 GMT


> On July 6, 2016, 11:38 p.m., Guangya Liu wrote:
> > src/slave/containerizer/mesos/isolators/appc/runtime.cpp, lines 215-219
> > <https://reviews.apache.org/r/49348/diff/6/?file=1437512#file1437512line215>
> >
> >     So for the case of sh=0,value=0,argv=1,Exec=1, what about the value of `Exec[1]...`
etc? Should not it be `./Exec[0] Exec[1] ... argv`

Thanks Guangya. Let's keep this open. 

It depends on whether or not users have the ability to overwrite.


> On July 6, 2016, 11:38 p.m., Guangya Liu wrote:
> > src/slave/containerizer/mesos/isolators/appc/runtime.cpp, line 265
> > <https://reviews.apache.org/r/49348/diff/6/?file=1437512#file1437512line265>
> >
> >     Seems you are losing the logic to handle logic in row 2 when there are arguments?

The logic seems fine to me here. That case is covered.


> On July 6, 2016, 11:38 p.m., Guangya Liu wrote:
> > src/slave/containerizer/mesos/isolators/appc/runtime.cpp, line 287
> > <https://reviews.apache.org/r/49348/diff/6/?file=1437512#file1437512line287>
> >
> >     s/WorkingDirectory/workingDirectory

good catch.


- Gilbert


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49348/#review141133
-----------------------------------------------------------


On July 5, 2016, 11:32 p.m., Srinivas Brahmaroutu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49348/
> -----------------------------------------------------------
> 
> (Updated July 5, 2016, 11:32 p.m.)
> 
> 
> Review request for mesos.
> 
> 
> Bugs: MESOS-4778
>     https://issues.apache.org/jira/browse/MESOS-4778
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added implementation to Appc Runtime Isolator.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/isolators/appc/runtime.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/49348/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Srinivas Brahmaroutu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message