mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gilbert Song <songzihao1...@gmail.com>
Subject Re: Review Request 49348: Added implementation to Appc Runtime Isolator.
Date Tue, 12 Jul 2016 19:26:46 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49348/#review141951
-----------------------------------------------------------



This patch looks good to me. Will give a ship it once the comments are addressed.


src/slave/containerizer/mesos/isolators/appc/runtime.cpp (lines 202 - 203)
<https://reviews.apache.org/r/49348/#comment207401>

    s/ignored/overwritten/g



src/slave/containerizer/mesos/isolators/appc/runtime.cpp (lines 260 - 261)
<https://reviews.apache.org/r/49348/#comment207402>

    could you use `const appc::spec::ImageManifest::App app = ...` here?


- Gilbert Song


On July 12, 2016, 9:15 a.m., Srinivas Brahmaroutu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49348/
> -----------------------------------------------------------
> 
> (Updated July 12, 2016, 9:15 a.m.)
> 
> 
> Review request for mesos.
> 
> 
> Bugs: MESOS-4778
>     https://issues.apache.org/jira/browse/MESOS-4778
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added implementation to Appc Runtime Isolator.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/isolators/appc/runtime.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/49348/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Srinivas Brahmaroutu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message