mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Neil Conway <neil.con...@gmail.com>
Subject Re: Review Request 49914: Improved the speed of 'MasterAPITest.UnreserveResources'.
Date Wed, 13 Jul 2016 10:09:10 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49914/#review142046
-----------------------------------------------------------




src/tests/api_tests.cpp (line 95)
<https://reviews.apache.org/r/49914/#comment207529>

    Rather than changing this for all tests implicitly, I'd prefer creating a `master::Flags`
and changing the allocation interval explicitly in the tests that benefit from it.



src/tests/api_tests.cpp (line 1074)
<https://reviews.apache.org/r/49914/#comment207530>

    Per other review comment, I'd opt for making this change in a separate review, and also
explaining why it is necessary -- i.e., it should be possible to avoid the 5-second delay
(e.g., by declining the initial offer) without rearranging when we connect the scheduler to
the master.


- Neil Conway


On July 11, 2016, 7:39 p.m., Abhishek Dasgupta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49914/
> -----------------------------------------------------------
> 
> (Updated July 11, 2016, 7:39 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, Neil Conway, and Vinod Kone.
> 
> 
> Bugs: MESOS-5732
>     https://issues.apache.org/jira/browse/MESOS-5732
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Overloaded createMasterFlags in MasterAPITest to increase
> the speed of 'MasterAPITest.ReserveResources' and
> 'MasterAPITest.UnreserveResources'.
> 
> 
> Diffs
> -----
> 
>   src/tests/api_tests.cpp 55e825ea6a3bd43c76dc67e8b90a97e8c9530a47 
> 
> Diff: https://reviews.apache.org/r/49914/diff/
> 
> 
> Testing
> -------
> 
> On Ubuntu 16.04:
> sudo make -j4 check
> 
> 
> Thanks,
> 
> Abhishek Dasgupta
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message