mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gilbert Song <songzihao1...@gmail.com>
Subject Re: Review Request 49232: Added appcManifest to ImageInfo and ProvisionInfo.
Date Fri, 15 Jul 2016 19:06:06 GMT


> On July 15, 2016, 6:42 a.m., Guangya Liu wrote:
> > src/slave/containerizer/mesos/provisioner/appc/store.cpp, line 199
> > <https://reviews.apache.org/r/49232/diff/11/?file=1444089#file1444089line199>
> >
> >     I recalled Gilbert asked why returning `Future` here but you dropped the comments
without any comment, can you please help explain?

It is because we have to do `spec::getManifest()` after we have the ImageId ready.


> On July 15, 2016, 6:42 a.m., Guangya Liu wrote:
> > src/slave/containerizer/mesos/provisioner/appc/store.cpp, line 200
> > <https://reviews.apache.org/r/49232/diff/11/?file=1444089#file1444089line200>
> >
> >     move this before L213.

+1.


> On July 15, 2016, 6:42 a.m., Guangya Liu wrote:
> > src/slave/containerizer/mesos/provisioner/provisioner.cpp, line 403
> > <https://reviews.apache.org/r/49232/diff/11/?file=1444091#file1444091line403>
> >
> >     4 spaces for the indent

Thanks Guangya.

@Srini, seems like you missed this one.


- Gilbert


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49232/#review142350
-----------------------------------------------------------


On July 14, 2016, 10:28 a.m., Srinivas Brahmaroutu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49232/
> -----------------------------------------------------------
> 
> (Updated July 14, 2016, 10:28 a.m.)
> 
> 
> Review request for mesos, Gilbert Song and Jie Yu.
> 
> 
> Bugs: MESOS-4778
>     https://issues.apache.org/jira/browse/MESOS-4778
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added appcManifest to ImageInfo and ProvisionInfo.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/containerizer.cpp e900d752b70165236a198f70c8cb24876a678e4b

>   src/slave/containerizer/mesos/provisioner/appc/store.cpp aaa0efe63e587b9e604082b52a3cb8c11545fbb9

>   src/slave/containerizer/mesos/provisioner/provisioner.hpp 48a05059969e068a0ee0d38b61be9e7104e3188d

>   src/slave/containerizer/mesos/provisioner/provisioner.cpp 6825742546a87c8148097e6e13a94592e3b6754e

>   src/slave/containerizer/mesos/provisioner/store.hpp 1d477ef13ddd24fd8badae0decaa4a2271ecc746

> 
> Diff: https://reviews.apache.org/r/49232/diff/
> 
> 
> Testing
> -------
> 
> Make Check.
> 
> 
> Thanks,
> 
> Srinivas Brahmaroutu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message