mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Klaus Ma <klaus1982...@gmail.com>
Subject Re: Review Request 49223: Fixed Value parsing code to only accept the canonical formats.
Date Thu, 21 Jul 2016 16:34:50 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49223/
-----------------------------------------------------------

(Updated July 22, 2016, 12:34 a.m.)


Review request for mesos and Benjamin Mahler.


Changes
-------

Handle empty Range & Set case.


Bugs: MESOS-5739
    https://issues.apache.org/jira/browse/MESOS-5739


Repository: mesos


Description (updated)
-------

Fixed Value parsing code to only accept the canonical formats.
NOTES: This patch isn't doing a complete validation against
the canonical format yet: the set entries is not validated as
conforming to the Values.Text format yet.


Diffs (updated)
-----

  src/common/values.cpp 7b8a8ea00bd4bd1a82c33be4438c26b2731b1dd8 
  src/tests/values_tests.cpp cc17b675d5d3768685b44a1cea64264dcbca80ba 
  src/v1/values.cpp ff1926f9ab26c3ac3ab62b6df3ce305f5d12f12e 

Diff: https://reviews.apache.org/r/49223/diff/


Testing
-------

make && make check


Thanks,

Klaus Ma


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message