mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From haosdent huang <haosd...@gmail.com>
Subject Re: Review Request 49555: Updated docker executor to use HealthCheck via library way.
Date Mon, 01 Aug 2016 13:13:59 GMT


> On Aug. 1, 2016, 10:19 a.m., Alexander Rukletsov wrote:
> > src/docker/executor.cpp, line 521
> > <https://reviews.apache.org/r/49555/diff/1/?file=1435661#file1435661line521>
> >
> >     do you need to `devolve` here?

Removed after rebase, thx.


> On Aug. 1, 2016, 10:19 a.m., Alexander Rukletsov wrote:
> > src/docker/executor.cpp, line 523
> > <https://reviews.apache.org/r/49555/diff/1/?file=1435661#file1435661line523>
> >
> >     do you need to `devolve` here?

Removed after rebase, thx.


- haosdent


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49555/#review144317
-----------------------------------------------------------


On Aug. 1, 2016, 1:13 p.m., haosdent huang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49555/
> -----------------------------------------------------------
> 
> (Updated Aug. 1, 2016, 1:13 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Benjamin Mahler, Gilbert Song, Jie Yu,
and Timothy Chen.
> 
> 
> Bugs: MESOS-5954
>     https://issues.apache.org/jira/browse/MESOS-5954
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Updated docker executor to use HealthCheck via library way.
> 
> 
> Diffs
> -----
> 
>   src/docker/executor.cpp 445628c9164facdd8bd812c5b45e3b2b886ebf0e 
> 
> Diff: https://reviews.apache.org/r/49555/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> haosdent huang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message