mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From haosdent huang <haosd...@gmail.com>
Subject Re: Review Request 50642: Implemented `CgroupsIsolatorProcess::initialize`.
Date Mon, 01 Aug 2016 18:11:09 GMT


> On Aug. 1, 2016, 3:10 a.m., Qian Zhang wrote:
> > src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp, lines 127-132
> > <https://reviews.apache.org/r/50642/diff/1/?file=1458768#file1458768line127>
> >
> >     Do we have to spawn each subsystem in this `initialize()` method? Or can we
just do it in `Subsystem::create()` (after a subsystem is created and loaded)?

I think it would be better manage the lifecylce of subsystems in the cgroups isolator, so
I put them here.


- haosdent


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50642/#review144298
-----------------------------------------------------------


On July 31, 2016, 5:48 p.m., haosdent huang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50642/
> -----------------------------------------------------------
> 
> (Updated July 31, 2016, 5:48 p.m.)
> 
> 
> Review request for mesos, Gilbert Song, Jie Yu, Qian Zhang, and Zhengju Sha.
> 
> 
> Bugs: MESOS-5041
>     https://issues.apache.org/jira/browse/MESOS-5041
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Implemented `CgroupsIsolatorProcess::initialize`.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/isolators/cgroups/cgroups.hpp 422b4653fc3cb3d14c94b93ff456625fc59fbb27

>   src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp bd20631a9650cf84e99c6489b2e92bc40ed764ca

> 
> Diff: https://reviews.apache.org/r/50642/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> haosdent huang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message