mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Guangya Liu <gyliu...@gmail.com>
Subject Review Request 50678: Do not set allocation_interval in allocator benchmark test.
Date Mon, 01 Aug 2016 22:59:52 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50678/
-----------------------------------------------------------

Review request for mesos, Benjamin Mahler and Jiang Yan Xu.


Repository: mesos


Description
-------

We already using `Clock::pause();` to manually drive the allocations,
so here we can remove the logic of set allocation_interval here.


Diffs
-----

  src/tests/hierarchical_allocator_tests.cpp e5576023e4aab930f0e2b1d82d8baa6569d852eb 

Diff: https://reviews.apache.org/r/50678/diff/


Testing
-------

make
make check

```
[ RUN      ] SlaveAndFrameworkCount/HierarchicalAllocator_BENCHMARK_Test.ResourceLabels/1
Using 1000 agents and 50 frameworks
Added 50 frameworks in 5231us
Added 1000 agents in 3.295297secs
round 0 allocate() took 2.323202secs to make 1000 offers after filtering 1000 offers
round 1 allocate() took 2.326269secs to make 1000 offers after filtering 2000 offers
round 2 allocate() took 2.393019secs to make 1000 offers after filtering 3000 offers
round 3 allocate() took 2.33054secs to make 1000 offers after filtering 4000 offers
round 4 allocate() took 2.388765secs to make 1000 offers after filtering 5000 offers
round 5 allocate() took 2.364473secs to make 1000 offers after filtering 6000 offers
round 6 allocate() took 2.631534secs to make 1000 offers after filtering 7000 offers
round 7 allocate() took 2.692875secs to make 1000 offers after filtering 8000 offers
round 8 allocate() took 2.653584secs to make 1000 offers after filtering 9000 offers
```

```
[ RUN      ] SlaveAndFrameworkCount/HierarchicalAllocator_BENCHMARK_Test.DeclineOffers/1
Using 1000 agents and 50 frameworks
Added 50 frameworks in 6797us
Added 1000 agents in 2.628263secs
round 0 allocate() took 2.207578secs to make 1000 offers after filtering  1000 offers
round 1 allocate() took 2.230511secs to make 1000 offers after filtering  2000 offers
round 2 allocate() took 2.238138secs to make 1000 offers after filtering  3000 offers
round 3 allocate() took 2.229707secs to make 1000 offers after filtering  4000 offers
round 4 allocate() took 2.239294secs to make 1000 offers after filtering  5000 offers
round 5 allocate() took 2.310338secs to make 1000 offers after filtering  6000 offers
round 6 allocate() took 2.30661secs to make 1000 offers after filtering  7000 offers
round 7 allocate() took 2.377254secs to make 1000 offers after filtering  8000 offers
round 8 allocate() took 2.399587secs to make 1000 offers after filtering  9000 offers
round 9 allocate() took 2.540271secs to make 1000 offers after filtering  10000 offers
```


Thanks,

Guangya Liu


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message