mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Guangya Liu <gyliu...@gmail.com>
Subject Review Request 50868: Using `OfferedResources` for benchmark test of `SuppressOffers`.
Date Fri, 05 Aug 2016 21:50:06 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50868/
-----------------------------------------------------------

Review request for mesos and Benjamin Mahler.


Repository: mesos


Description
-------

The current benchmark test of `SuppressOffers` is using `Allocation`
to specify the resources from an `OfferCallback`, but here seems
using `OfferedResources` maybe better, as here we are actually
constructing the offers on each agent, but the `Allocation` is an
allocator concept and it means the resources allocated for a specified
framework.


Diffs
-----

  src/tests/hierarchical_allocator_tests.cpp cbed333f497016fe2811f755028796012b41db77 

Diff: https://reviews.apache.org/r/50868/diff/


Testing
-------

make
make check

```
./bin/mesos-tests.sh --benchmark  --gtest_filter="*HierarchicalAllocator_BENCHMARK_Test.SuppressOffers/0"
[==========] Running 1 test from 1 test case.
[----------] Global test environment set-up.
[----------] 1 test from SlaveAndFrameworkCount/HierarchicalAllocator_BENCHMARK_Test
[ RUN      ] SlaveAndFrameworkCount/HierarchicalAllocator_BENCHMARK_Test.SuppressOffers/0
Using 1000 agents and 1 frameworks
Added 1 frameworks in 841us
Added 1000 agents in 480991us
allocate() took 264196us to make 1000 offers with 0 out of 1 frameworks suppressing offers
allocate() took 270110us to make 1000 offers with 0 out of 1 frameworks suppressing offers
allocate() took 270098us to make 1000 offers with 0 out of 1 frameworks suppressing offers
allocate() took 264314us to make 1000 offers with 0 out of 1 frameworks suppressing offers
allocate() took 268732us to make 1000 offers with 0 out of 1 frameworks suppressing offers
[       OK ] SlaveAndFrameworkCount/HierarchicalAllocator_BENCHMARK_Test.SuppressOffers/0
(4511 ms)
[----------] 1 test from SlaveAndFrameworkCount/HierarchicalAllocator_BENCHMARK_Test (4511
ms total)

[----------] Global test environment tear-down
[==========] 1 test from 1 test case ran. (4522 ms total)
[  PASSED  ] 1 test.
```


Thanks,

Guangya Liu


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message