mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jie Yu <yujie....@gmail.com>
Subject Re: Review Request 49849: Implemented `CpuSubsystem`.
Date Thu, 18 Aug 2016 22:46:06 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49849/#review146135
-----------------------------------------------------------


Fix it, then Ship it!




Made some adjustment while committing. Please take a look and adjust the following patches.
Thanks!


src/slave/containerizer/mesos/isolators/cgroups/subsystem.cpp (lines 34 - 36)
<https://reviews.apache.org/r/49849/#comment212510>

    No need to prepend with leading underscore for these variables.



src/slave/containerizer/mesos/isolators/cgroups/subsystem.cpp (line 46)
<https://reviews.apache.org/r/49849/#comment212520>

    I meant to have a static `create` method for each subsystem.



src/slave/containerizer/mesos/isolators/cgroups/subsystems/cpu.hpp (line 44)
<https://reviews.apache.org/r/49849/#comment212521>

    I'd hide this constructor.


- Jie Yu


On Aug. 18, 2016, 4:09 p.m., haosdent huang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49849/
> -----------------------------------------------------------
> 
> (Updated Aug. 18, 2016, 4:09 p.m.)
> 
> 
> Review request for mesos, Gilbert Song, Jie Yu, Qian Zhang, and Zhengju Sha.
> 
> 
> Bugs: MESOS-5042
>     https://issues.apache.org/jira/browse/MESOS-5042
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Implemented `CpuSubsystem`.
> 
> 
> Diffs
> -----
> 
>   src/CMakeLists.txt 4362d472707193aa09343ef69f070e2d3efda324 
>   src/Makefile.am d389e02584cfb1a00067cd30de1364118d1c46c7 
>   src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp 7e205a3eea4ad89faccf564bdb2ad0041fdee249

>   src/slave/containerizer/mesos/isolators/cgroups/constants.hpp c45d88092f3fe497373dfeaa8346aef9126c7b8b

>   src/slave/containerizer/mesos/isolators/cgroups/subsystem.hpp 5f52a076a1fa3a21d886cb961ddeed5046a38d7c

>   src/slave/containerizer/mesos/isolators/cgroups/subsystem.cpp a30ecafcbecc9d3b6eeea2b04dcb4d278750af41

>   src/slave/containerizer/mesos/isolators/cgroups/subsystems/cpu.hpp PRE-CREATION 
>   src/slave/containerizer/mesos/isolators/cgroups/subsystems/cpu.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/49849/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> haosdent huang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message