mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Guangya Liu <gyliu...@gmail.com>
Subject Re: Review Request 50599: Passed allocated GPUs to 'devices' entry of 'docker::Flags'.
Date Mon, 22 Aug 2016 07:45:12 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50599/#review146308
-----------------------------------------------------------




src/slave/containerizer/docker.hpp (line 507)
<https://reviews.apache.org/r/50599/#comment212682>

    period to the end.
    
    ```
    // Devices exposition control.
    ```



src/slave/containerizer/docker.cpp (line 669)
<https://reviews.apache.org/r/50599/#comment212683>

    kill this



src/slave/containerizer/docker.cpp (lines 706 - 707)
<https://reviews.apache.org/r/50599/#comment212688>

    ```
    const string nvidiaData =
      nvidiaDataPrefix + boost::lexical_cast<string>(gpu.minor);
    ```



src/slave/containerizer/docker.cpp (line 719)
<https://reviews.apache.org/r/50599/#comment212694>

    period to the end


- Guangya Liu


On 八月 15, 2016, 7:29 a.m., Yubo Li wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50599/
> -----------------------------------------------------------
> 
> (Updated 八月 15, 2016, 7:29 a.m.)
> 
> 
> Review request for mesos, Benjamin Mahler, Guangya Liu, Kevin Klues, and Rajat Phull.
> 
> 
> Bugs: MESOS-5795
>     https://issues.apache.org/jira/browse/MESOS-5795
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added a new string entry 'devices' to 'docker::Flags' to
> indicate host devices exposed into docker container, and
> passed allocated GPUs to it.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/docker.hpp f2a06065cf99fed934c2c1ffc47461ec8a97f50d 
>   src/slave/containerizer/docker.cpp 5c1ee8e467d1c54c60b67dc5275ef71e1bb90723 
> 
> Diff: https://reviews.apache.org/r/50599/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Yubo Li
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message