mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From haosdent huang <haosd...@gmail.com>
Subject Re: Review Request 51115: Replaced a static isolator cleanup function with lambda.
Date Mon, 22 Aug 2016 13:04:42 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51115/#review146340
-----------------------------------------------------------




src/slave/containerizer/mesos/containerizer.cpp (line 1965)
<https://reviews.apache.org/r/51115/#comment212725>

    Need return with explicit type declaration here, otherwise would compile fail in clang.
https://builds.apache.org/job/Mesos/2609/
    
    A follow up patch here https://reviews.apache.org/r/51285/ to fix this. :)


- haosdent huang


On Aug. 15, 2016, 10:56 p.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51115/
> -----------------------------------------------------------
> 
> (Updated Aug. 15, 2016, 10:56 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Benjamin Mahler, Gilbert Song, and Kevin
Klues.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Replaced a static isolator cleanup function with lambda.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/containerizer.cpp 9b0cca2feabc3c9fcc2b84f3eb6dffac1253a649

> 
> Diff: https://reviews.apache.org/r/51115/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message