mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Qian Zhang <zhang...@cn.ibm.com>
Subject Re: Review Request 51293: Fixed a typo in the comment of `Subsystem::watch`.
Date Tue, 23 Aug 2016 07:54:46 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51293/#review146486
-----------------------------------------------------------




src/slave/containerizer/mesos/isolators/cgroups/subsystem.hpp (line 99)
<https://reviews.apache.org/r/51293/#comment212964>

    I think we are not returning `Nothing`, instead we are returning `ContainerLimitation`
on success, right?


- Qian Zhang


On Aug. 23, 2016, 12:11 a.m., haosdent huang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51293/
> -----------------------------------------------------------
> 
> (Updated Aug. 23, 2016, 12:11 a.m.)
> 
> 
> Review request for mesos, Gilbert Song, Jie Yu, and Qian Zhang.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Fixed a typo in the comment of `Subsystem::watch`.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/isolators/cgroups/subsystem.hpp 6dca38cfdd360288c03a7a01aebbf15e3cbc5dce

> 
> Diff: https://reviews.apache.org/r/51293/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> haosdent huang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message