mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <jos...@mesosphere.io>
Subject Re: Review Request 50326: Added script to build mesos-resolve.
Date Mon, 03 Oct 2016 23:04:45 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50326/#review151241
-----------------------------------------------------------



LGTM, but this is a somewhat under-utilized utility.  I'd recommend discarding it for now.

`mesos-resolve` imports and creates a `MasterDetector` underneath.  The `MasterDetector` was
(relatively recently) modularized, making this utility less relevant (because it doesn't support
modules).  AFAICT, no tests depend on this either.

- Joseph Wu


On Sept. 6, 2016, 3:06 p.m., Srinivas Brahmaroutu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50326/
> -----------------------------------------------------------
> 
> (Updated Sept. 6, 2016, 3:06 p.m.)
> 
> 
> Review request for mesos, Alex Clemmer and Joseph Wu.
> 
> 
> Bugs: MESOS-5792
>     https://issues.apache.org/jira/browse/MESOS-5792
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added script to build mesos-resolve.
> 
> 
> Diffs
> -----
> 
>   src/cli/CMakeLists.txt c0120cd7f4ef8dc275edbd5cb1a4a6e23952ec63 
> 
> Diff: https://reviews.apache.org/r/50326/diff/
> 
> 
> Testing
> -------
> 
> cmake .. && make mesos-resolve
> 
> 
> Thanks,
> 
> Srinivas Brahmaroutu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message