mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <jos...@mesosphere.io>
Subject Re: Review Request 52311: Pass the user value from executor of switch_user flag is set.
Date Tue, 04 Oct 2016 01:34:17 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52311/#review151278
-----------------------------------------------------------




src/slave/slave.cpp (line 4219)
<https://reviews.apache.org/r/52311/#comment219632>

    Even though you've moved the user-checking logic above, the custom executor case is still
returning without a `user` always set.



src/tests/slave_tests.cpp (line 793)
<https://reviews.apache.org/r/52311/#comment219630>

    This test broke because your change is slightly incorrect.  You'll notice that the command
executor only adds the `--user` flag if `hasRootfs` is true.


- Joseph Wu


On Oct. 1, 2016, 3:42 p.m., Sivaram Kannan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52311/
> -----------------------------------------------------------
> 
> (Updated Oct. 1, 2016, 3:42 p.m.)
> 
> 
> Review request for mesos and Joseph Wu.
> 
> 
> Bugs: MESOS-5856
>     https://issues.apache.org/jira/browse/MESOS-5856
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Pass the user value from executor of switch_user flag is set. Update the test case SlaveTest.GetExecutorInfo
with the expected Command from 2 to 3.
> 
> 
> Diffs
> -----
> 
>   src/slave/slave.cpp 958a33b962d6385e37af9372d9f8edd1f70bf676 
>   src/tests/slave_tests.cpp 3471314675a11f850aaaa371e47b648bb43ee27e 
> 
> Diff: https://reviews.apache.org/r/52311/diff/
> 
> 
> Testing
> -------
> 
> 1. Run the mesos-logrotate-logger with un-priviledged user and verify whether the logs
are getting rotated. 
> 2. Run the mesos-logrotate-logger as root user and verify whether the logs are getting
rotated.
> 
> 
> Thanks,
> 
> Sivaram Kannan
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message