mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gastón Kleiman <gas...@mesosphere.com>
Subject Re: Review Request 52434: Improved handling of tmp file creation in health check test.
Date Tue, 04 Oct 2016 16:14:18 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52434/
-----------------------------------------------------------

(Updated Oct. 4, 2016, 4:14 p.m.)


Review request for mesos, Alexander Rukletsov and haosdent huang.


Changes
-------

Revert the last revision, since it made the tests stop passing.


Repository: mesos


Description
-------

The tmp file used in the HealthStatusChange test is now created inside
the tmp directory created for the test suite. This ensures that it will
be cleaned up on tear down.


Diffs (updated)
-----

  src/tests/health_check_tests.cpp f4a63e2f5def022bf4469920861e6a5af229af96 

Diff: https://reviews.apache.org/r/52434/diff/


Testing
-------

make check GTEST_FILTER="HealthCheckTest.*" V=0


Thanks,

Gastón Kleiman


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message