mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <jos...@mesosphere.io>
Subject Re: Review Request 52462: Ported ReviewBot script to Windows.
Date Tue, 04 Oct 2016 20:29:58 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52462/
-----------------------------------------------------------

(Updated Oct. 4, 2016, 1:29 p.m.)


Review request for mesos, Benjamin Hindman, Daniel Pravat, Artem Harutyunyan, Alex Clemmer,
and Vinod Kone.


Repository: mesos


Description
-------

Changes which script ReviewBot uses to apply reviews and 
what script ReviewBot runs if on Windows.


Diffs
-----

  support/verify_reviews.py f14951b753ffbc1a939d1991d7bb901741efe388 

Diff: https://reviews.apache.org/r/52462/diff/


Testing (updated)
-------

On Windows:
python support/verify_reviews.py a b 1
// ^ Fake username and password, so as to not post any reviews.

Tested successful build and unsuccessful build (introduced a syntax error in libprocess).

---

TODO:
Wait for this: https://issues.apache.org/jira/browse/INFRA-12681
Then test run: https://builds.apache.org/job/Mesos-Windows-Reviewbot/


Thanks,

Joseph Wu


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message