mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gastón Kleiman <gas...@mesosphere.com>
Subject Re: Review Request 52432: Updated and reenabled 'HealthCheckTest.GracePeriod'.
Date Wed, 05 Oct 2016 13:00:37 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52432/
-----------------------------------------------------------

(Updated Oct. 5, 2016, 1 p.m.)


Review request for mesos, Alexander Rukletsov and haosdent huang.


Changes
-------

Added another assertion.


Bugs: MESOS-1653
    https://issues.apache.org/jira/browse/MESOS-1653


Repository: mesos


Description
-------

This test was disabled in 2014 because it was considered flaky. I
updated it and ran it 1000 times without a single failure.


Diffs (updated)
-----

  src/tests/health_check_tests.cpp f4a63e2f5def022bf4469920861e6a5af229af96 

Diff: https://reviews.apache.org/r/52432/diff/


Testing
-------

bin/mesos-tests.sh --verbose --gtest_filter="HealthCheckTest.GracePeriod" --break-on-error
--gtest_repeat=1000


Thanks,

Gastón Kleiman


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message