mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gastón Kleiman <gas...@mesosphere.com>
Subject Re: Review Request 52556: Added the MESOS_RUNTIME_DIRECTORY executor env variable.
Date Mon, 10 Oct 2016 16:20:14 GMT


> On Oct. 10, 2016, 3:32 p.m., Jiang Yan Xu wrote:
> > src/launcher/executor.cpp, lines 903-910
> > <https://reviews.apache.org/r/52556/diff/2/?file=1525587#file1525587line903>
> >
> >     You didn't start this but I wonder why we can't consistently use the flags,
which can be provided through environment variables, i.e., use `flags.load("MESOS_", &argc,
&argv);` above.
> >     
> >     That question aside, I don't think we need to be concerned about backwards-compatibility
here: this is the command executor bundled with the agent so they are upgraded together. i.e.,
we are sure that the agent is setting the new variable.

Wouldn't then the tasks started between the moment in which the binary is overwritten and
the moment in which the Mesos Agent is restarted fail?


- Gastón


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52556/#review151918
-----------------------------------------------------------


On Oct. 10, 2016, 12:35 p.m., Gastón Kleiman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52556/
> -----------------------------------------------------------
> 
> (Updated Oct. 10, 2016, 12:35 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Anand Mazumdar, Jie Yu, and Jiang Yan
Xu.
> 
> 
> Bugs: MESOS-6288
>     https://issues.apache.org/jira/browse/MESOS-6288
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This environment variable points to the directory containing the
> binaries used by the Mesos Agent. It will eventually replace the
> `--launcher-dir` executor flag.
> 
> 
> Diffs
> -----
> 
>   docs/executor-http-api.md 50b4cb4efff48bcc56330b81bd7c4c217b8a22b5 
>   src/launcher/executor.cpp 8a1051b886a0c95d19ff370e5c77d9c4033c8b61 
>   src/slave/slave.cpp d30001bc0d1798311ba3966f67aadc6be2c92306 
> 
> Diff: https://reviews.apache.org/r/52556/diff/
> 
> 
> Testing
> -------
> 
> `make check`
> 
> 
> Thanks,
> 
> Gastón Kleiman
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message