mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <jos...@mesosphere.io>
Subject Re: Review Request 50912: Added the infrastructure for a new python-based CLI.
Date Mon, 10 Oct 2016 18:51:31 GMT


> On Oct. 5, 2016, 5:36 p.m., Vinod Kone wrote:
> > src/cli_new/bin/main.py, line 22
> > <https://reviews.apache.org/r/50912/diff/8/?file=1517723#file1517723line22>
> >
> >     why the space?
> >     
> >     also alphabetical ordering.

This separates standard python libraries from local libraries (`config.py` and `__init__.py`).

Should be fine as is.


> On Oct. 5, 2016, 5:36 p.m., Vinod Kone wrote:
> > src/cli_new/bootstrap, line 19
> > <https://reviews.apache.org/r/50912/diff/8/?file=1517725#file1517725line19>
> >
> >     who sets VIRTUAL_ENV env variable?

This is something virtualenv sets.  For example, the shell script:
https://github.com/pypa/virtualenv/blob/15.0.3/virtualenv_embedded/activate.sh#L43-L44


- Joseph


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50912/#review151263
-----------------------------------------------------------


On Oct. 4, 2016, 9:12 p.m., Kevin Klues wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50912/
> -----------------------------------------------------------
> 
> (Updated Oct. 4, 2016, 9:12 p.m.)
> 
> 
> Review request for mesos, Haris Choudhary and Joseph Wu.
> 
> 
> Bugs: MESOS-6008
>     https://issues.apache.org/jira/browse/MESOS-6008
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added the infrastructure for a new python-based CLI.
> 
> 
> Diffs
> -----
> 
>   src/cli_new/.gitignore PRE-CREATION 
>   src/cli_new/README.md PRE-CREATION 
>   src/cli_new/activate PRE-CREATION 
>   src/cli_new/bin/config.py PRE-CREATION 
>   src/cli_new/bin/main.py PRE-CREATION 
>   src/cli_new/bin/mesos PRE-CREATION 
>   src/cli_new/bootstrap PRE-CREATION 
>   src/cli_new/deactivate PRE-CREATION 
>   src/cli_new/lib/mesos/__init__.py PRE-CREATION 
>   src/cli_new/lib/mesos/docopt.py PRE-CREATION 
>   src/cli_new/lib/mesos/exceptions.py PRE-CREATION 
>   src/cli_new/lib/mesos/plugins/__init__.py PRE-CREATION 
>   src/cli_new/lib/mesos/plugins/base.py PRE-CREATION 
>   src/cli_new/lib/mesos/util.py PRE-CREATION 
>   src/cli_new/mesos.bash_completion PRE-CREATION 
>   src/cli_new/pip-requirements.txt PRE-CREATION 
>   src/cli_new/pylint.config PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/50912/diff/
> 
> 
> Testing
> -------
> 
> $ cd src/cli_new
> $ ./bootstrap
> $ source activate
> 
> (mesos-cli) $ mesos --help
> 
> 
> Thanks,
> 
> Kevin Klues
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message