mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <jos...@mesosphere.io>
Subject Re: Review Request 52309: Pass the user variable from library to binary.
Date Tue, 11 Oct 2016 00:19:44 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52309/#review152087
-----------------------------------------------------------


Fix it, then Ship it!




Once these last few things are tweaked, this commit should be good-to-go.  I'll commit it
with the rest of the chain, when the whole chain is ready.


src/slave/container_loggers/lib_logrotate.cpp (lines 143 - 144)
<https://reviews.apache.org/r/52309/#comment220813>

    s/executorInfo/`ExecutorInfo`/
    s/loggerUser/the `loggerUser`/
    
    And period at the end.



src/slave/container_loggers/lib_logrotate.cpp (line 145)
<https://reviews.apache.org/r/52309/#comment220814>

    Unless we've accidentally included the `std` namespace somewhere, this shouldn't compile
unless it's `std::string`.


- Joseph Wu


On Oct. 5, 2016, 8:07 p.m., Sivaram Kannan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52309/
> -----------------------------------------------------------
> 
> (Updated Oct. 5, 2016, 8:07 p.m.)
> 
> 
> Review request for mesos and Joseph Wu.
> 
> 
> Bugs: MESOS-5856
>     https://issues.apache.org/jira/browse/MESOS-5856
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Pass the user variable from library to binary.
> 
> 
> Diffs
> -----
> 
>   src/slave/container_loggers/lib_logrotate.cpp 0ca2b3d7dbb57c11c0740aed3914a6b75329af99

> 
> Diff: https://reviews.apache.org/r/52309/diff/
> 
> 
> Testing
> -------
> 
> 1. Run the mesos-logrotate-logger with un-priviledged user and verify whether the logs
are getting rotated. 
> 2. Run the mesos-logrotate-logger as root user and verify whether the logs are getting
rotated.
> 
> 
> Thanks,
> 
> Sivaram Kannan
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message