mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <>
Subject Re: Review Request 40410: Libprocess Reinit: Move MetricsProcess instantiation into process.cpp.
Date Wed, 12 Oct 2016 21:25:25 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated Oct. 12, 2016, 2:25 p.m.)

Review request for mesos, Greg Mann, Artem Harutyunyan, Joris Van Remoortere, and Vinod Kone.


Rename `metrics_singleton` to `metrics`.  Some whitespace tweaks.  Added `process::initialize`
in a couple places.

Bugs: MESOS-3934

Repository: mesos


The metrics singleton must be unified with `process::initialize` so 
that it also falls under the scope of reinitialization.  The singleton 
must also not be guarded by `Once`.

Diffs (updated)

  3rdparty/libprocess/include/process/metrics/metrics.hpp 54487ab2614c7f8e8df10d1e0c39880a6cf5bde3

  3rdparty/libprocess/src/metrics/metrics.cpp 4ab3ac7fb7688df937ff62d496d9104628324018 
  3rdparty/libprocess/src/process.cpp f1d746c52cfe659f5cd7da4b7a6424ff585619a3 
  3rdparty/libprocess/src/tests/system_tests.cpp 0f4d0424689522337806ba2227ec4330c700e17e



Tests done in a subsequent review.


Joseph Wu

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message