mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <>
Subject Re: Review Request 40413: Libprocess Reinit: Move ReaperProcess instantiation into process.cpp.
Date Wed, 12 Oct 2016 21:25:27 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated Oct. 12, 2016, 2:25 p.m.)

Review request for mesos, Greg Mann, Artem Harutyunyan, Joris Van Remoortere, and Vinod Kone.


Renamed `reaper_singleton` to `reaper`.  Some whitespace tweaks.

Bugs: MESOS-3934

Repository: mesos


The reaper singleton must be unified with `process::initialize` so 
that it also falls under the scope of reinitialization.  The singleton 
must also not be guarded by `Once`.

Diffs (updated)

  3rdparty/libprocess/include/process/reap.hpp d7e0fa381df63a9ca7d438d5cea0631e1b0ec7ee 
  3rdparty/libprocess/src/process.cpp f1d746c52cfe659f5cd7da4b7a6424ff585619a3 
  3rdparty/libprocess/src/reap.cpp 5fc2a4d67a3a6fe56005fc2c2d16d4983d53b83a 



Tests done in a subsequent review.


Joseph Wu

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message